Taylor Blau [off-list ref] writes:
quoted
- const char *filename = dry_run ? "/dev/null" : git_path_fetch_head(the_repository);
+ const char *filename = (!write_fetch_head
+ ? "/dev/null"
+ : git_path_fetch_head(the_repository));
Ah, because dry_run ==> !write_fetch_head, so this is an equivalent
translation. Makes sense.
Yup, now dry_run is merely one of the two cases we turn
write_fetch_head off, and the logic to prevent us from writing
FETCH_HEAD (hopefully without any other side effect) was already
there in this function.
Test coverage all looks good, thanks for working on this. I don't think
there's anything left, so this would be great after 2.28 is released.
Reviewed-by: Taylor Blau [off-list ref]
Thanks.