Re: [PATCH v4 10/13] bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C
From: Junio C Hamano <hidden>
Date: 2020-07-08 21:39:01
Miriam Rubio [off-list ref] writes:
quoted hunk
@@ -856,6 +858,81 @@ static int bisect_autostart(struct bisect_terms *terms) return res; } + int mark_for_removal(const char *refname, const struct object_id *oid, + int flag, void *cb_data) +{ + struct string_list *refs = cb_data; + char *ref = xstrfmt("refs/bisect%s", refname); + string_list_append(refs, ref); + return 0; +}
Funny indentation at the beginning, and worse yet, triggers an error with -Werror=missing-prototypes. What is the relationship between this one and the similarly-named on in bisect.c?