Re: [PATCH v3 4/4] ref-filter: add support for %(contents:size)
From: Junio C Hamano <hidden>
Date: 2020-07-07 22:21:34
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2020-07-09 · Re: [PATCH v3 4/4] ref-filter: add support for %(contents:size) · Junio C Hamano <hidden>
- 2020-07-09 · Re: [PATCH v3 4/4] ref-filter: add support for %(contents:size) · Christian Couder <hidden>
- 2020-07-09 · Re: [PATCH v3 4/4] ref-filter: add support for %(contents:size) · Junio C Hamano <hidden>
- 2020-07-08 · Re: [PATCH v3 4/4] ref-filter: add support for %(contents:size) · Junio C Hamano <hidden>
- 2020-07-07 · Re: [PATCH v3 4/4] ref-filter: add support for %(contents:size) · Junio C Hamano <hidden>
Christian Couder [off-list ref] writes:
+ else if (atom->u.contents.option == C_LENGTH)
+ v->s = xstrfmt("%ld", strlen(subpos));Please squash something like this in. 32-bit builds are failing. ref-filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ref-filter.c b/ref-filter.c
index 8ec28f0535..73d8bfa86d 100644
--- a/ref-filter.c
+++ b/ref-filter.c@@ -1257,7 +1257,7 @@ static void grab_sub_body_contents(struct atom_value *val, int deref, void *buf) else if (atom->u.contents.option == C_BODY_DEP) v->s = xmemdupz(bodypos, bodylen); else if (atom->u.contents.option == C_LENGTH) - v->s = xstrfmt("%ld", strlen(subpos)); + v->s = xstrfmt("%"PRIuMAX, (uintmax_t)strlen(subpos)); else if (atom->u.contents.option == C_BODY) v->s = xmemdupz(bodypos, nonsiglen); else if (atom->u.contents.option == C_SIG)