Re: [PATCH v3 3/4] t6300: test refs pointing to tree and blob
From: Junio C Hamano <hidden>
Date: 2020-07-07 19:32:55
Christian Couder [off-list ref] writes:
Adding tests for refs pointing to tree and blob shows that
we care about testing both positive ("see, my shiny new toy
does work") and negative ("and it won't do nonsensical
things when given an input it is not designed to work with")
cases.Nice.
quoted hunk
Signed-off-by: Christian Couder <redacted> --- t/t6300-for-each-ref.sh | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index da59fadc5d..371e45e5ad 100755 --- a/t/t6300-for-each-ref.sh +++ b/t/t6300-for-each-ref.sh@@ -650,6 +650,28 @@ test_atom refs/tags/signed-long contents "subject line body contents $sig" +test_expect_success 'set up refs pointing to tree and blob' ' + git update-ref refs/mytrees/first refs/heads/master^{tree} && + git ls-tree refs/mytrees/first one >one_info && + test $(cut -d" " -f2 one_info) = "blob" && + blob_hash=$(cut "-d " -f1 one_info | cut -d" " -f3) && + git update-ref refs/myblobs/first "$blob_hash"
Wouldn't it be sufficient to say git update-ref refs/myblobs/first refs/heads/master:one instead of the last 4 lines in this set-up?
+' + +test_atom refs/mytrees/first subject "" +test_atom refs/mytrees/first contents:subject "" +test_atom refs/mytrees/first body "" +test_atom refs/mytrees/first contents:body "" +test_atom refs/mytrees/first contents:signature "" +test_atom refs/mytrees/first contents "" + +test_atom refs/myblobs/first subject "" +test_atom refs/myblobs/first contents:subject "" +test_atom refs/myblobs/first body "" +test_atom refs/myblobs/first contents:body "" +test_atom refs/myblobs/first contents:signature "" +test_atom refs/myblobs/first contents ""
All makes sense. We require "git for-each-ref" that asks for these atoms in the format to silently exit successfully when the object at the tip of a ref is of these types, so all these test_atom should succeed. Nicely written.
test_expect_success 'set up multiple-sort tags' ' for when in 100000 200000 do