Thread (6 messages) 6 messages, 2 authors, 2020-07-08

Re: [PATCH v2 0/2] Add support for %(contents:size) in ref-filter

From: Jeff King <hidden>
Date: 2020-07-07 05:02:50

On Thu, Jul 02, 2020 at 04:08:43PM +0200, Christian Couder wrote:
This is version 2 of a very small patch series to teach ref-filter
about %(contents:size).

Version 1 consisted on a single patch which is available here:

https://lore.kernel.org/git/20200701132308.16691-1-chriscool@tuxfamily.org/ (local)

As suggested by Peff, I added a preparatory patch (1/2) to clean up
the documentation about the %(contents:XXXX) format specifiers.
Thanks, I think it looks much nicer.
The other difference with V1 is that there are more tests in patch
2/2. These new tests required a small helper function to be
introduced.
I'm still not sure why %(objectsize) isn't sufficient here. Is there
some use case that's served by %(contents:size) that it wouldn't work
for? Or are we just trying to make it more discoverable when you're
looking at the contents already?

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help