Re: [PATCH 1/2] commit-reach: create repo_is_descendant_of()

On 6/29/2020 9:40 AM, Taylor Blau wrote:

On Wed, Jun 17, 2020 at 05:24:28PM +0000, Derrick Stolee via GitGitGadget wrote:

quoted

+int is_descendant_of(struct commit *commit, struct commit_list *with_commit)
+{
+	return repo_is_descendant_of(the_repository, commit, with_commit);
+}
+

I don't think that it makes a big deal either way, but I wonder about
moving 'repo_is_descendant_of' to the header file, and making
'is_descendant_of' be 'static inline int' as you defined it here.

Since this has already graduated up to master already, I don't think
that it's worth going back just to shuffle this code around, but I was
wondering if you had any specific reason for doing it this way.

I have good news for you. [1]

[1] https://lore.kernel.org/git/20200623184222.54201-1-carenas@gmail.com/ (local)

Thanks,
-Stolee