Thread (1 message) 1 message, 1 author, 2020-06-22

Re: [PATCH 0/2] drop specialized knowledge from generic worktree code

From: Junio C Hamano <hidden>
Date: 2020-06-22 17:34:18

Eric Sunshine [off-list ref] writes:
This patch series removes specialized knowledge from the libified
worktree code about how front-end "git worktree list" wants worktrees
sorted, and instead makes it the responsibility of "git worktree list"
itself to do the sorting.

It is built atop es/worktree-duplicate-paths since that series adds
another caller of get_worktrees() which this series touches.

A possible argument against this patch series is that some other entity
may someday want worktrees sorted in the same fashion as "git worktree
list", however, that seems a case of YAGNI.
Is anything hurting to have the "mostly extra" flag and its handling
that is added only to support "worktree list"?  That would be
another possible argument against this clean-up.

Having said that, I think this is good.

Thanks.  Will queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help