Re: [PATCH] unpack-trees: do not set SKIP_WORKTREE on submodules
From: Matheus Tavares Bernardino <hidden>
Date: 2020-06-18 20:29:42
On Thu, Jun 18, 2020 at 4:20 PM Elijah Newren [off-list ref] wrote:
On Thu, Jun 18, 2020 at 7:34 AM Matheus Tavares Bernardino [off-list ref] wrote:quoted
On Wed, Jun 17, 2020 at 9:24 PM Elijah Newren [off-list ref] wrote:quoted
When we notice an initialized submodule that does not match the sparsity patterns, we should print a warning just like we do for unmerged and dirty entries.Yeah, seems like a good approach. Thanks for the explanations. Some of the test cases in mt/grep-sparse-checkout will have to be adjusted with this change. Should I reroll the series based on the patch you will send or do you prefer to adjust them in your patch (and make it dependent on mt/grep-sparse-checkout)?Ah, good catch. Your series came first, is longer, and is reviewed other than the submodule/config stuff that needs someone more familiar with that area than me. Since my patch needs more work anyway, how about I rebase my patch on top of your work, and make sure to ping you as a reviewer to make sure I don't mess anything up?
Sounds good :) Thanks