Re: [PATCH v2] gc: recommend `git gc --prune=now` instead of `git prune`

Hi all,

Thank you Bjarmason & Junio. If Denton doesn't have other concerns,
I'll start working on adding bash completion for "git prune".

Best,
John Lin

Junio C Hamano [off-list ref] 於 2020年6月10日 週三 上午12:03寫道：

Ævar Arnfjörð Bjarmason [off-list ref] writes:

quoted

On Tue, Jun 09 2020, John Lin via GitGitGadget wrote:

quoted

From: John Lin <redacted>

`git prune` is a plumbing command and should not be run directly by
users. The corresponding porcelain command is `git gc`, which is
mentioned in the man page of `git prune`.

This change feels incomplete without a change to git-prune's
documentation, see 8d308b3540 ("Documentation: point git-prune users to
git-gc", 2008-04-29).

I.e. it still talks about "in most cases you shouldn't run this", but
here we are removing a case where it would otherwise make sense because
the user shouldn't use it directly.

I think instead the small change that makes the most sense here is to
just add "prune" to completions,...

That's perfectly reasonable stance to take.