Thread (1 message) 1 message, 1 author, 2020-06-09

Re: [PATCH] Fixup! Add t/helper/test-reftable.c

From: Junio C Hamano <hidden>
Date: 2020-06-09 20:45:37

hanwen@google.com writes:
Subject: Re: [PATCH] Fixup! Add t/helper/test-reftable.c
I do not see a step with "Add t/helper/test-reftable.c" as its
subject; is this supposed to be squashed into "Hookup unittests for
the reftable library." or somewhere else?

I also notice, with or without this squashed in, 775c540f (Hookup
unittests for the reftable library., 2020-06-05) does not compile
cleanly.  Since you are relatively new to this project (even though
you are very experienced and capable), I probably should let you
know that in this project each patch in a series is expected to
cleanly compile and pass the testsuite, not just the endstate.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help