Thread (7 messages) 7 messages, 4 authors, 2020-06-09

Re: Change Native Windows shell

From: Johannes Schindelin <hidden>
Date: 2020-06-09 11:18:56

Hi Steven,

On Mon, 8 Jun 2020, Steven Penny wrote:
On Mon, Jun 8, 2020 at 5:46 PM Johannes Schindelin wrote:
quoted
That assumes that PowerShell is installed, which is not guaranteed,
either.

Besides, quoting rules are most likely different with PowerShell than what
Git assumes, so you will have to take care of that, too.

Finally, there are plenty of tips out there in the internet that simply
expect a POSIX shell to execute those script snippets. Any user would be
completely (and unnnecessarily) puzzled if those snippets won't work with
their Git for Windows.

In short: it would be unwise for me to accept this change into Git for
Windows, at least as-is.
I found a workaround. It seems as long as PAGER or similar is not get, then
Git just tries to call `less.exe`. I didnt realize when I first posted this,
but native Windows Less is available:

https://github.com/jftuga/less-Windows/releases

So I am just bundling that with my Windows native Git:

https://github.com/nu8/gulf/releases
What is your plan to address concerns of users trying to run popular
hooks? Those example hooks, and recommended hooks, that you can find e.g.
on StackOverflow are all POSIX shell scripts.

Ciao,
Johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help