Re: [PATCH] t5608: avoid say and use skip_all for consistency

Johannes Schindelin [off-list ref] writes:

Hi Carlo,

quoted

Subject : Re: [PATCH] t5608: avoid say and use skip_all for consistency

It might make quite a bit of sense to add a visual indicator to "say" to
make it clear that it is not a verb, but a function name. Otherwise
non-native speakers such as myself (and maybe even native speakers) will
stumble over the grammar of this sentence when trying to parse it.

These would work better for me:

	t5608: avoid `say` and use `skip_all` for consistency

or

	t5608: avoid say() and use skip_all() for consistency

On Thu, 21 May 2020, Carlo Marcelo Arenas Belón wrote:

quoted

Printing a message directly to stdout could affect TAP processing
and is not really needed, as there is a standard way to skip all
tests that could be used instead (including a message).

While at it, update the message to better reflect the use of
booleans and get rid of the prerequisite.

Makes sense. I would have added a sentence to say that _all_ three test
cases were guarded by the very same prereq, so `skip_all` is just much
faster and idempotent.

Otherwise, the patch looks good to me.

Thanks, both.  I see a v2 has already been posted, so hopefully that
would be the final version.