Thread (1 message) 1 message, 1 author, 2020-05-18

Re: [PATCH 1/7] Redirect grep's stderr top null too.

From: Junio C Hamano <hidden>
Date: 2020-05-18 18:20:20

Darren Tucker [off-list ref] writes:
Subject: Re: [PATCH 1/7] Redirect grep's stderr top null too.
Our patch title typically looks like

	area: title without initial Capitalization and full stop

Perhaps

	Subject: autoconf: redirect grep's stderr to null
Prevents pollution of configure output on platforms that don't have
grep -a.
Our log message typically describes the state without this patch in
the current tense to highlight the problem being solved, and then
orders the person who is updating the system to "make the codebase
like so", e.g.

	When the tested platform's 'grep' does not support the '-a'
	option, an error message would be given to its standard
	error stream, polluting the output.

	Redirect the error message to /dev/null, in addition to the
	standard output, to squelch it.

or something along that style.

Thanks.
quoted hunk
Signed-off-by: Darren Tucker <redacted>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 66aedb9288..4effc82b76 100644
--- a/configure.ac
+++ b/configure.ac
@@ -526,7 +526,7 @@ if test -n "$ASCIIDOC"; then
 	esac
 fi
 
-if grep -a ascii configure.ac >/dev/null; then
+if grep -a ascii configure.ac >/dev/null 2>&1; then
   AC_MSG_RESULT([Using 'grep -a' for sane_grep])
   SANE_TEXT_GREP=-a
 else
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help