Re: [PATCH] t/test_lib: avoid naked bash arrays in file_lineno

Carlo Marcelo Arenas Belón [off-list ref] writes:

On Thu, May 07, 2020 at 09:52:12PM +0200, Johannes Schindelin wrote:

quoted

On Wed, 6 May 2020, Carlo Marcelo Arenas Belón wrote:

quoted

Enclose the bash specific code inside an eval to avoid parsing errors
and while at it, simplify the logic so that instead of traversing the
callstack just pop the two topmost entries that are required.

I would be okay with that, but that's not what the patch does:

FWIW that was the intention, but luckily Junio quickly predicted it was
most likely buggy and so has been since made obsolete by:

  https://lore.kernel.org/git/20200507175706.19986-1-carenas@gmail.com/ (local)

Heh, don't give me too much credit.  I just noticed that they cannot
be implementing the same thing, but I couldn't tell if the new
behaviour was something you two agreed to be better, and asked for a
clarification.

In any case, the "just protect with eval '' block to avoid hurting
other shells" version should be the first step.  Improving it
further is a separate topic.

Thanks.