Re: [PATCH v3] bugreport: collect list of populated hooks
From: Junio C Hamano <hidden>
Date: 2020-05-07 23:06:24
Emily Shaffer [off-list ref] writes:
quoted
test_expect_success 'indicates populated hooks' ' - test_when_finished rm git-bugreport-hooks.txt && - test_when_finished rm -fr .git/hooks &&I'm not sure it's necessary to lose these two lines. Especially the generated bugreport I'd like to clean up.
I do not care either way, actually. I left it so that it would be easier to debug the test by looking at the output.
quoted
+ rm -fr .git/hooks && mkdir .git/hooks && - write_script .git/hooks/applypatch-msg && - write_script .git/hooks/prepare-commit-msg.sample && + for hook in applypatch-msg prepare-commit-msg.sample + do + write_script ".git/hooks/$hook" <<-\EOF || return 1 + echo "hook $hook exists" + EOF + done &&I like this placeholder script a lot.
I actually don't. At least the final version should not quote EOF (otherwise $hook will appear verbatim).
quoted
git bugreport -s hooks && grep applypatch-msg git-bugreport-hooks.txt && ! grep prepare-commit-msg git-bugreport-hooks.txt -- 2.26.2-447-gd61d20c9b4
Thanks.