Thread (56 messages) flat view 56 messages, 4 authors, 2020-07-15

Re: [PATCH v2 0/8] commit-graph: drop CHECK_OIDS, peel in callers

From: Jeff King <hidden>
Date: 2020-05-07 20:42:07

On Tue, May 05, 2020 at 06:07:09PM -0600, Taylor Blau wrote:
Here's a small re-roll of my series to move peeling outside of the
commit-graph internals, and drop the CHECK_OIDS flag. This re-roll was
promised in [1], and only updates the messages used in the new progress
meters. For convenience, a range-diff from v1 is included below.
I just reviewed v1. :) But I think the revised progress messages in v2
are much better.

The overall direction looks very good to me. I left a couple of
comments. Nothing too major, but I think there are some things worth
addressing (leaks, and more robust error checking in the final patch).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help