Thread (1 message) 1 message, 1 author, 2020-05-04

Re: [PATCH] commit-graph: avoid memory leaks

From: Junio C Hamano <hidden>
Date: 2020-05-04 21:09:08

Jonathan Tan [off-list ref] writes:
A fuzzer running on the entry point provided by fuzz-commit-graph.c
revealed a memory leak when parse_commit_graph() creates a struct
bloom_filter_settings and then returns early due to error. Fix that
error by always freeing that struct first (if it exists) before
returning early due to error.

While making that change, I also noticed another possible memory leak -
when the BLOOMDATA chunk is provided but not BLOOMINDEXES. Also fix that
error.

Signed-off-by: Jonathan Tan <redacted>
---
Here's a memory leak fix revealed by a fuzzer running at $DAYJOB, and
another one that I noticed while making that fix.
---
Thanks.  The patch looks good.

Will queue.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help