Re: [PATCH v3 3/3] credential: handle `credential.<partial-URL>.<key>` again
From: Johannes Schindelin <hidden>
Date: 2020-05-01 19:59:13
From: Johannes Schindelin <hidden>
Date: 2020-05-01 19:59:13
Hi Junio, On Wed, 29 Apr 2020, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:quoted
quoted
while the other branch lacks the extra blank line just before the single quote is closed. I queued 850ef627 (SQUASH??? ...Thank you for pointing that out. I already did that: ... Do you want me to send another iteration, for completeness' sake?Then if I squash 850ef627 on my end, we'd be in sync, so unless there is any other change, no need to resend it.
Perfect, thanks!
Have we got enough eyeballs that looked at the patches already?
I would obviously prefer more reviews. Having said that, GitHub Desktop rolled out a new release this past Monday with the MinGit backport I prepared with these here patches, and the only additional report at https://github.com/desktop/desktop/issues/9597 talks about macOS (and the MinGit backport is Windows-only). Which I take as good news for the robustness and correctness of the fixes. Ciao, Dscho