Re: [PATCH v2] userdiff: support Markdown
From: Johannes Sixt <hidden>
Date: 2020-05-01 14:26:31
From: Johannes Sixt <hidden>
Date: 2020-05-01 14:26:31
Am 01.05.20 um 13:49 schrieb Ash Holland:
On Thu Apr 30, 2020 at 11:31 AM BST, Junio C Hamano wrote:quoted
Taking all that together, my suspicion is "^ {0,3}#{1,6}[ \t]" i.e. "possibly slightly indented run of 6 hashes, with a whitespace to catch the headers with real contents and nothing else" might be more practically useful. I dunno.Sure, that looks plausible. I don't have a strong opinion on whether it's more useful to be consistent (and show the last heading, even if it doesn't contain any text) or to try as hard as possible to just show "some text", even if it's not the last heading, but two people have now suggested changing it, so I'll submit a v3 with your suggested pattern.
The pattern above captures only the hashmarks, but not the text of the header. I suggest to append ".*". -- Hannes