Thread (2 messages) 2 messages, 2 authors, 2020-04-29

Re: Re* [PATCH 0/4] t: replace incorrect test_must_fail usage (part 5)

From: Taylor Blau <hidden>
Date: 2020-04-29 22:41:25

On Wed, Apr 29, 2020 at 03:36:25PM -0700, Junio C Hamano wrote:
Taylor Blau [off-list ref] writes:
quoted
Hmm. I say this as somebody who just re-rolled a series to add two
'test_might_fail umask 022' lines, so am a little disappointed to learn
that this is not considered to be idiomatic.
...
Junio: do you want another reroll of that series? :/
The one I saw and remember was two new umask calls protected in POSIXPERM
prerequisite but without test-might-fail involved.

Perhaps there is nothing to reroll?  Or perhaps I am not checking my
mailbox often enough?
You are checking your mailbox often enough, but unfortunately my memory
isn't as good as I thought ;). You're right: those calls are in
POSIXPERM-only tests, and don't have a 'test_might_fail' in front of
them as such.

That was easy ;).

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help