Thread (20 messages) 20 messages, 5 authors, 2020-06-04

Re: [PATCH v2 1/2] t5537: use test_write_lines, indented heredocs for readability

From: Jonathan Nieder <hidden>
Date: 2020-04-24 17:17:44

Possibly related (same subject, not in this thread)

Taylor Blau wrote:
Subject: [PATCH] t5537: use test_write_lines, indented heredocs for readability

A number of spots in t5537 use the non-indented heredoc '<<EOF' when
they would benefit from instead using '<<-EOF' or simply
test_write_lines.

In preparation for adding new tests in a good style and being consistent
with the surrounding code, update the existing tests to improve their
readability.

Suggested-by: Junio C Hamano <redacted>
Signed-off-by: Taylor Blau <redacted>
---
 t/t5537-fetch-shallow.sh | 70 ++++++++++------------------------------
 1 file changed, 17 insertions(+), 53 deletions(-)
The commit message is missing the mention of \EOF quoting.

See "git log --grep='modernize style'" for some examples about how to
write this kind of commit message without it getting tedious.

That said, I think it's fine --- just mentioning that for the future.

Reviewed-by: Jonathan Nieder <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help