Re: [PATCH 4/4] progress.c: silence cgcc suggestion about internal linkage
flat view
From: Ramsay Jones <hidden>
Date: 2020-04-24 00:58:57
On 23/04/2020 14:47, Đoàn Trần Công Danh wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Đoàn Trần Công Danh <redacted> --- progress.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/progress.c b/progress.c index 19805ac646..fb53a2ec0c 100644 --- a/progress.c +++ b/progress.c@@ -50,7 +50,9 @@ static volatile sig_atomic_t progress_update; * These are only intended for testing the progress output, i.e. exclusively * for 'test-tool progress'. */ +extern int progress_testing; /* to silence sparse: internal linkage */ int progress_testing; +extern uint64_t progress_test_ns; /* to silence sparse: internal linkage */ uint64_t progress_test_ns = 0; void progress_test_force_update(void); /* To silence -Wmissing-prototypes */ void progress_test_force_update(void)
My preference would be to add these extern declarations to the progress.h header file, with a note that they are only used by the 't/helper/test-progress.c' test helper. (Also, remove the extern declarations from test-progress.c, of course). But this works as well. :D ATB, Ramsay Jones