Thread (1 message) 1 message, 1 author, 2020-04-01

Re: [PATCH] sequencer: honor GIT_REFLOG_ACTION

From: Junio C Hamano <hidden>
Date: 2020-04-01 20:46:26

"Elijah Newren via GitGitGadget" [off-list ref] writes:
From: Elijah Newren <redacted>

There is a lot of code to honor GIT_REFLOG_ACTION throughout git,
including some in sequencer.c; unfortunately, reflog_message() and its
callers ignored it.  Instruct reflog_message() to check the existing
environment variable, and use it when present as an override to
action_name().

Also restructure pick_commits() to only temporarily modify
GIT_REFLOG_ACTION for a short duration and then restore the old value,
Yeah, I was wondering what you'd be doing about that setenv().  The
code around there looks good.  I briefly wondered what would happen
when the environment variable is totally unset upon entry, but then
we'd have the fallback value of action_name(opts) in there, so we
won't have a risk of running xstrdup(NULL).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help