[PATCH v2 5/9] update-ref: drop unused argument for `parse_refname`
From: Patrick Steinhardt <hidden>
Date: 2020-03-30 13:46:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
The `parse_refname` function accepts a `struct strbuf *input` argument that isn't used at all. As we're about to convert commands to not use a strbuf anymore but instead an end pointer, let's drop this argument now to make the converting commit easier to review. Signed-off-by: Patrick Steinhardt <redacted> --- builtin/update-ref.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/builtin/update-ref.c b/builtin/update-ref.c
index 559475681e..6f2aba916b 100644
--- a/builtin/update-ref.c
+++ b/builtin/update-ref.c@@ -50,7 +50,7 @@ static const char *parse_arg(const char *next, struct strbuf *arg) * the argument. Die if C-quoting is malformed or the reference name * is invalid. */ -static char *parse_refname(struct strbuf *input, const char **next) +static char *parse_refname(const char **next) { struct strbuf ref = STRBUF_INIT;
@@ -189,7 +189,7 @@ static const char *parse_cmd_update(struct ref_transaction *transaction, if (!skip_prefix(next, " ", &next)) die("update: missing space after command"); - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("update: missing <ref>");
@@ -226,7 +226,7 @@ static const char *parse_cmd_create(struct ref_transaction *transaction, if (!skip_prefix(next, " ", &next)) die("create: missing space after command"); - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("create: missing <ref>");
@@ -262,7 +262,7 @@ static const char *parse_cmd_delete(struct ref_transaction *transaction, if (!skip_prefix(next, " ", &next)) die("delete: missing space after command"); - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("delete: missing <ref>");
@@ -300,7 +300,7 @@ static const char *parse_cmd_verify(struct ref_transaction *transaction, if (!skip_prefix(next, " ", &next)) die("verify: missing space after command"); - refname = parse_refname(input, &next); + refname = parse_refname(&next); if (!refname) die("verify: missing <ref>");
--
2.26.0
Attachments
- signature.asc [application/pgp-signature] 833 bytes