Thread (1 message) 1 message, 1 author, 2020-03-27

Re: [PATCH 7/9] update-ref: move transaction handling into `update_refs_stdin()`

From: Junio C Hamano <hidden>
Date: 2020-03-27 21:44:44

Patrick Steinhardt [off-list ref] writes:
While the actual logic to update the transaction is handled in
`update_refs_stdin()`, the transaction itself is started and committed
in `cmd_update_ref()` itself. This makes it hard to handle transaction
abortion and commits as part of `update_refs_stdin()` itself, ...
It is not offhand clear why it makes any difference, especially
because there is only a single caller of update_refs_stdin()
function, but let's see how this move makes things easier in [8/9]
and [9/9].

The patch itself looks like a bug-free no-op change.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help