Thread (1 message) 1 message, 1 author, 2020-03-20

Re: [PATCH] t3419: prevent failure when run with EXPENSIVE

From: Junio C Hamano <hidden>
Date: 2020-03-20 22:24:25

Elijah Newren [off-list ref] writes:
quoted
-               rm -rf .git/rebase-apply
+               rm -rf .git/rebase-merge .git/rebase-apply
        '
 }
Good catch, thanks.  Perhaps we just want to invoke 'git rebase
--quit' and let it clean up instead of manually doing so ourselves,
since it may buy us some future-proofing in case we ever want to move
the place we store rebase state?
I started writing "I would agree 100% if this script were not about
testing 'rebase', but using 'rebase' itself for a framework to test
'rebase'???" but then if 'rebase --quit' fails to clear these, what
we are likely to see is that the next test to fail, so it probably
is an OK approach.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help