Re: [PATCH] git-gui--askpass: coerce answers to UTF-8 on Windows
From: Junio C Hamano <hidden>
Date: 2020-03-11 20:17:21
"Johannes Schindelin via GitGitGadget" [off-list ref] writes:
quoted hunk
diff --git a/git-gui--askpass b/git-gui--askpass index 4277f30c411..b0704e6d91e 100755 --- a/git-gui--askpass +++ b/git-gui--askpass@@ -56,6 +56,11 @@ proc finish {} { } } + # On Windows, force the encoding to UTF-8: it is what `git.exe` expects + if {$::tcl_platform(platform) eq {windows}} {
The indentation looks funny here. Dedent one level?
+ set ::answer [encoding convertto utf-8 $::answer] + }
Looks correct (assuming that $::answer we got is Unicode "string", and I think that is a sane assumpton as it came directly from a textvariable bound to an entry widget).
puts $::answer set ::rc 0 } base-commit: 63a58457e094c9c9bbf562b872009d32f1f88133