Thread (1 message) 1 message, 1 author, 2020-03-03

Re: [PATCH v2 1/2] remote: drop "explicit" parameter from remote_ref_for_branch()

From: Junio C Hamano <hidden>
Date: 2020-03-03 22:22:35

Jeff King [off-list ref] writes:
On Tue, Mar 03, 2020 at 09:51:07AM -0800, Junio C Hamano wrote:
quoted
quoted
But unlike remote names, there's no default case for the remote branch
name.
Up to this point, it is well written and easy to read.  I think
"there is no case where a default name for the remoate branch is
used" would be even more easy to read.

In any case, if there is no case that default name, I understand
that explicit is always set to 1?
quoted
In any case where we don't set "explicit", we'd just an empty
string anyway.
Sorry, but I cannot parse this.  But earlier, you established that
there is no case that a default is used, so is there any case where
we don't set "explicit"?  I don't get it.
Maybe more clear:
...
Yes, that looks fine to me.
Thanks for a clarification.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help