Re: [PATCH 3/3] t: drop debug `cat` calls

Martin Ågren [off-list ref] writes:

For the first patch 1/3, if we lose the cat entirely, we risk bugs in
*git* being hidden.

Yes, as Peff already said, the change to explicitly test if the file
exists makes perfect sense.

For the hunk in patch 2/3, I first thought it was in the same
category, before I realized that kwdelfile.c disappearing would be
a bug in *p4* as opposed to *git p4*.  Since we're not in the
business of testing/verifying other people's software, we can
afford to drop that call entirely.

It is ">kwdelfile.c" shell redirection that creates that file.  I
agree with you that preparing for a bug that "p4 add -t ktext
kwdelfile.c" or "p4 submit" removes the file is a little too much.