Thread (1 message) 1 message, 1 author, 2020-02-13

Re: [PATCH 05/13] rev-list: factor out bitmap-optimized routines

From: Junio C Hamano <hidden>
Date: 2020-02-13 18:34:51

Jeff King [off-list ref] writes:
There are a few operations in rev-list that are optimized for bitmaps.
Rather than having the code inline in cmd_rev_list(), let's move them
into helpers. This not only makes the flow of the main function simpler,
but it lets us replace the complex "can we do the optimization?"
conditionals with a series of early returns from the functions. That
also makes it easy to add comments explaining those conditions.
... and these new comments makes the resulting code much easier to
follow.  Nicely done.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help