Re: SHA1dc on mac
From: Eric Sunshine <hidden>
Date: 2020-02-12 16:46:46
On Wed, Feb 12, 2020 at 3:57 AM Mike Hommey [off-list ref] wrote:
If I'm not mistaken in my reading of the various files involved, it looks like for some reason, building git on mac leads to using Apple Common Crypto for SHA1, rather than SHA1dc, which seems unfortunate. Is that really expected?
There was a discussion on this topic a while back[1], and it does seem that the behavior you describe is intentional[2].
More generally, at this point, should anything other than SHA1dc be supported as a build option at all?
The conclusion [2,3] was that it likely would make sense to drop support for Apple's CommonCrypto altogether, although nobody has yet stepped up to do the work. [1]: https://lore.kernel.org/git/CAMYxyaVQyVRQb-b0nVv412tMZ3rEnOfUPRakg2dEREg5_Ba5Ag@mail.gmail.com/T/ (local) [2]: https://lore.kernel.org/git/20160102234923.GA14424@gmail.com/ (local) [3]: https://lore.kernel.org/git/CAPig+cQ5kKAt2_RQnqT7Rn=uGmHV9VvxpQ+UgDPOj=D=pq6arg@mail.gmail.com/ (local)