Re: [PATCH] advice: refactor advise API

On 2/10/2020 6:56 PM, Heba Waly wrote:

On Tue, Feb 11, 2020 at 3:38 AM Derrick Stolee [off-list ref] wrote:

quoted

I definitely tend to recommend more tests than most, but perhaps this
unit test is overkill? You demonstrate a good test below using a real
Git command, which should be sufficient. If the "turn this message off"
part gets removed, then you will still have coverage of your method.
It just won't require a test change because it would not modify behavior.

I see your point but I wanted to make sure advise_ng honors the config
variable using tests 2 & 3 in `t0018-advice.sh`
and `t7004-tag.sh` didn't seem like a good place to add these tests.

You're right. I wasn't considering the case of not showing the message
with respect to the config.

-Stolee