Re: [PATCH v5 4/6] config: split repo scope to local and worktree
From: Junio C Hamano <hidden>
Date: 2020-01-27 23:09:50
"Matthew Rogers via GitGitGadget" [off-list ref] writes:
quoted hunk
diff --git a/t/helper/test-config.c b/t/helper/test-config.c index 214003d5b2..6695e463eb 100644 --- a/t/helper/test-config.c +++ b/t/helper/test-config.c@@ -44,8 +44,10 @@ static const char *scope_name(enum config_scope scope) return "system"; case CONFIG_SCOPE_GLOBAL: return "global"; - case CONFIG_SCOPE_REPO: + case CONFIG_SCOPE_LOCAL: return "repo"; + case CONFIG_SCOPE_WORKTREE: + return "worktree";
It used to be only "repo"; now we give either "repo" or "worktree".
quoted hunk
case CONFIG_SCOPE_CMDLINE: return "cmdline"; default:diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh index 7b4e1a63eb..90196e2862 100755 --- a/t/t1308-config-set.sh +++ b/t/t1308-config-set.sh@@ -259,7 +259,7 @@ test_expect_success 'iteration shows correct origins' ' value=from-repo origin=file name=.git/config - scope=repo + scope=local
But the test expects "local". This patch cannot be correct. I recall fixing this manually when I queued the previous round to 'pu'. Please double check.