Re: [PATCH v3 1/4] clean: demonstrate a bug with pathspecs

On Fri, Jan 17, 2020 at 7:20 AM Derrick Stolee [off-list ref] wrote:

On 1/16/2020 3:21 PM, Derrick Stolee via GitGitGadget wrote:

quoted

From: Derrick Stolee <redacted>

b9670c1f5e (dir: fix checks on common prefix directory, 2019-12-19)

Thanks for fixing my typo here.

quoted

modified the way pathspecs are handled when handling a directory
during "git clean -f <path>". While this improved the behavior for
known test breakages, it also regressed in how the clean command
handles cleaning a specified file.

Add a test case that demonstrates this behavior. This test passes
before b9670c1f5e then fails after.

Helped-by: Kevin Willford [off-list ref]
Signed-off-by: Derrick Stolee <redacted>
Reviewed-by: Elijah Newren <redacted>

Do we need your sign-off here, too?

I figured I didn't change the code, and the list already independently
saw your submission and sign-off, so I assumed that a "Reviewed-by"
was more appropriate.  If I'm wrong or people would just prefer me to
also add a Signed-off-by, I'm happy to add one.  And if it is, then it
should also be added to the last patch in the series from Peff.

If Junio wants it and it's easier for him to just edit-in for both of
these commits:
   Signed-off-by: Elijah Newren [off-list ref]

or I can send a re-roll.  But I'll assume it's not necessary if I
don't hear otherwise.