Thread (1 message) 1 message, 1 author, 2020-01-07

Re: [PATCH v2 2/2] graph: fix lack of color in horizontal lines

From: Junio C Hamano <hidden>
Date: 2020-01-07 21:51:48

"Derrick Stolee via GitGitGadget" [off-list ref] writes:
From: Derrick Stolee <redacted>

In some cases, horizontal lines in rendered graphs can lose their
coloring. This is due to a use of graph_line_addch() instead of
graph_line_write_column(). Using a ternary operator to pick the
character is nice for compact code, but we actually need a column to
provide the color.

Add a test to t4215-log-skewed-merges.sh to prevent regression.

Reported-by: Jeff King <redacted>
Signed-off-by: Derrick Stolee <redacted>
---
Thanks.  Looks good.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help