Thread (53 messages) 53 messages, 5 authors, 2020-01-17

Re: [PATCH v2 9/9] ci: include the built-in `git add -i` in the `linux-gcc` job

From: Johannes Schindelin <hidden>
Date: 2020-01-01 22:10:55

Hi Stolee,

On Thu, 26 Dec 2019, Derrick Stolee wrote:
On 12/25/2019 6:57 AM, Johannes Schindelin via GitGitGadget wrote:
quoted
From: Johannes Schindelin <redacted>

This job runs the test suite twice, once in regular mode, and once with
a whole slew of `GIT_TEST_*` variables set.

Now that the built-in version of `git add --interactive` is
feature-complete, let's also throw `GIT_TEST_ADD_I_USE_BUILTIN` into
that fray.

Signed-off-by: Johannes Schindelin <redacted>
---
 ci/run-build-and-tests.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
index ff0ef7f08e..4df54c4efe 100755
--- a/ci/run-build-and-tests.sh
+++ b/ci/run-build-and-tests.sh
@@ -20,6 +20,7 @@ linux-gcc)
 	export GIT_TEST_OE_DELTA_SIZE=5
 	export GIT_TEST_COMMIT_GRAPH=1
 	export GIT_TEST_MULTI_PACK_INDEX=1
+	export GIT_TEST_ADD_I_USE_BUILTIN=1
 	make test
I see that I need to add this to the test-coverage builds.
Thank you for catching this!

It makes me wonder whether the test-coverage builds should use some `sed`
invocation on the `ci/run-build-and-tests.sh` script, though, so that you
do not have to edit the Azure Pipelines definition manually all the time?

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help