Re: [PATCH v3 1/4] git-p4: yes/no prompts should sanitize user text

Johannes Schindelin [off-list ref] writes:

Hi Junio,

On Fri, 13 Dec 2019, Junio C Hamano wrote:

quoted

Denton Liu [off-list ref] writes:

quoted

quoted

@@ -4170,3 +4175,4 @@ def main():

 if __name__ == '__main__':
     main()
+

Spurious trailing line. Perhaps we could make GGG error out on
whitespace errors before submissions are allowed?

I think you are asking the tool for too much support.

It may help a lot more if we gave a Makefile target (or two) that
the contributors can run before going public.  Perhaps


	O=origin/master
	upstream-check::
		git log -p --check $(O)..

that can be used like so:

	$ make upstream-check
	$ make O=gitster/next upstream-check

That way, those who use format-patch+email without GGG or those who
push to a shared repository to be reviewed among the peer developers
before going public would benefit, not just GGG users.

Hmm?

I'd like that a lot, _and_ I think GitGitGadget could learn the trick of
running that `Makefile` target and report failures back to the PR
_especially_ because GitGitGadget knows the base branch of the PR.

Yup.  That's the right approach---provide a common base that
everybody can use, and then teach the tool help its users with it.
That way, the improvement won't be limited to the audience of a
single tool.