Re: [PATCH v2 2/2] gitk: rename "commit summary" to "commit reference"
From: Junio C Hamano <hidden>
Date: 2019-12-13 20:39:41
Denton Liu [off-list ref] writes:
From: Beat Bolli <redacted> Now that the commit reference format has a canonical name, let's use this name in gitk's UI and implementation. Signed-off-by: Beat Bolli <redacted> [dl: based the patch on gitk's tree] Signed-off-by: Denton Liu <redacted> --- gitk | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
I think this one makes sense, even though I am on the fence about patch 1/2. Thanks.
quoted hunk
diff --git a/gitk b/gitk index d07e3302de..17346b4c5c 100755 --- a/gitk +++ b/gitk@@ -2640,7 +2640,7 @@ proc makewindow {} { {mc "Diff selected -> this" command {diffvssel 1}} {mc "Make patch" command mkpatch} {mc "Create tag" command mktag} - {mc "Copy commit summary" command copysummary} + {mc "Copy commit reference" command copyreference} {mc "Write commit to file" command writecommit} {mc "Create new branch" command mkbranch} {mc "Cherry-pick this commit" command cherrypick}@@ -9426,7 +9426,7 @@ proc mktaggo {} { mktagcan } -proc copysummary {} { +proc copyreference {} { global rowmenuid autosellen set format "%h (%s, %ad)"@@ -9434,10 +9434,10 @@ proc copysummary {} { if {$autosellen < 40} { lappend cmd --abbrev=$autosellen } - set summary [eval exec $cmd $rowmenuid] + set reference [eval exec $cmd $rowmenuid] clipboard clear - clipboard append $summary + clipboard append $reference } proc writecommit {} {