Re: [PATCH 2/8] Revert "dir.c: make 'git-status --ignored' work within leading directories"
From: Denton Liu <hidden>
Date: 2019-12-09 21:32:24
Hi Elijah, On Mon, Dec 09, 2019 at 08:47:39PM +0000, Elijah Newren via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
diff --git a/t/t7061-wtstatus-ignore.sh b/t/t7061-wtstatus-ignore.sh index 0c394cf995..ded7f97181 100755 --- a/t/t7061-wtstatus-ignore.sh +++ b/t/t7061-wtstatus-ignore.sh@@ -43,11 +43,14 @@ test_expect_success 'status untracked directory with --ignored -u' ' test_cmp expected actual ' cat >expected <<\EOF -?? untracked/uncommitted +?? untracked/ !! untracked/ignored EOF -test_expect_success 'status prefixed untracked directory with --ignored' ' +test_expect_failure 'status of untracked directory with --ignored works with or without prefix' ' + git status --porcelain --ignored | grep untracked/ >actual &&
Can we break this pipe up into two invocations so that we don't have a git command in the upstream of a pipe? Thanks, Denton P.S. Perhaps in the future, we (I) could try to extend chainlint so that it catches this and git commands in non-assignment command substitutions... I think that would be pretty nice.
+ test_cmp expected actual && + git status --porcelain --ignored untracked/ >actual && test_cmp expected actual ' -- gitgitgadget