Re: [PATCH v4 00/13] Add --pathspec-from-file option

2 messages, 2 authors, 2019-12-05 · open the first message on its own page

Re: [PATCH v4 00/13] Add --pathspec-from-file option

From: Junio C Hamano <hidden>
Date: 2019-12-04 19:25:46

Alexandr Miloslavskiy [off-list ref] writes:
On 03.12.2019 17:55, Junio C Hamano wrote:
quoted
quoted
Changes from V3:
Yikes, perhaps our mails crossed or something?  I think the previous
round is already in 'next'.

Let's wait and see they cook enough to graduate to 'master', and
build a separate series on top to teach other commands the option
using the facility introduced by the current series (which is the
first 6 patches you sent here).
My intent is to support more commands, so I was working on other
patches in the background. Today more patches were ready and I wasn't
sure whether to submit another topic or continue the old one. After
some thinking, I decided to continue the old one.
Well I've split the new patches into its own topic to queue on the
am/pathspec-f-f-checkout branch, that builds directly on top of the
am/pathspec-from-file branch, for now.  I suspect that they may want
to be two topics (i.e. for "add" and for "checkout/restore"), but
I'd like to keep them out of 'next' either way for a while until the
base topic proves to be solid enough.
Please give me an advice: when the time comes, shall I prepare even
more patches and submit a massive branch, or shall I submit today's
remaining patches, then wait again? I imagine that massive branches
are scary and will deter reviewers?
Scary will probably not be an issue for the follow-up topics around
the pathspec-from-file theme, but a huge topic tends to wear out the
author and the reviewers, inviting trivial bugs that would otherwise
be found easily go unnoticed.

Thanks.

Re: [PATCH v4 00/13] Add --pathspec-from-file option

From: Alexandr Miloslavskiy <hidden>
Date: 2019-12-05 10:54:43

On 04.12.2019 20:25, Junio C Hamano wrote:
Scary will probably not be an issue for the follow-up topics around
the pathspec-from-file theme, but a huge topic tends to wear out the
author and the reviewers, inviting trivial bugs that would otherwise
be found easily go unnoticed.
OK, thanks! I will pause for now and wait until existing patches are in 
`master`.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help