Thread (1 message) 1 message, 1 author, 2019-12-02

Re: [PATCH v2] t4210: skip i18n tests that don't work on FreeBSD

From: Junio C Hamano <hidden>
Date: 2019-12-02 17:02:04

Jeff King [off-list ref] writes:
On Wed, Nov 27, 2019 at 05:15:07PM +0000, Ed Maste wrote:
quoted
Extend test-lib.sh to add a REGEX_ILLSEQ prereq, set it on FreeBSD, and
add !REGEX_ILLSEQ to the two affected tests.
Thanks, this is much nicer.
quoted
+FreeBSD)
+	test_set_prereq REGEX_ILLSEQ
+	test_set_prereq POSIXPERM
+	test_set_prereq BSLASHPSPEC
+	test_set_prereq EXECKEEPSPID
+	;;
I scratched my head at these for a minute, but I see you are just
covering the bits set in the "*" case that we now no longer trigger.

It would probably be cleaner to set them ahead of time and just unset
them selectively in MINGW, etc. But we don't have any way to unset a
prereq, so lets' go with this for now. :)
Thanks, both.  Queued.  Will merge to 'next' shortly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help