Hi Andreas,

On Sat, 30 Nov 2019, Andreas Schwab wrote:

On Nov 30 2019, Junio C Hamano wrote:

quoted

IOW, we cannot take advantage of that POSIX guarantee in the
codepaths that use our internal API.  So...

But it's still a good practice to follow.

An even better practice is to focus on what's important.

You could, for example, review the original patches again that needed this
fixup, to make sure that nothing similar lurks in them. That would seem to
me certainly more meaningful than harping on POSIX semantics in a context
where they do not actually matter.

Ciao,
Johannes