Re: [PATCH] test: use test_must_be_empty F instead of test_cmp empty F

Am 26.11.19 um 21:02 schrieb Denton Liu:

quoted

diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
index 0b20b07e68..3a3d8d3bd5 100755
--- a/t/t9010-svn-fe.sh
+++ b/t/t9010-svn-fe.sh

@@ -53,9 +53,7 @@ text_no_props () {
 	printf "%s\n" "$text"
 }

->empty
-
-test_expect_success 'empty dump' '
+test_expect_success PIPE 'empty dump' '

How come we need the PIPE prereq here? At the top of this file, we have

	if test_have_prereq !PIPE
	then
		skip_all="svn dumpfile importer testing requires the PIPE prerequisite"
		test_done
	fi

which should guarantee PIPE at this point already.

Right, we haven't needed it since 7236a34c98 (t9010-*.sh: skip all tests
if the PIPE prereq is missing, 2017-09-17).  Thanks for catching this!

My patch had been gathering dust here already before that time, and
sometime along the way I did a sloppy rebase.  Didn't see it before
sending because I was focusing on "can we remove the empty file?".  O_o

René