Re: [PATCH v3 22/22] t7700: stop losing return codes of git commands
From: Denton Liu <hidden>
Date: 2019-11-25 23:57:08
From: Denton Liu <hidden>
Date: 2019-11-25 23:57:08
Hi Junio, On Sat, Nov 23, 2019 at 10:49:44AM +0900, Junio C Hamano wrote:
Denton Liu [off-list ref] writes:quoted
- objsha1=$(git verify-pack -v pack-$packsha1.idx | head -n 1 | - sed -e "s/^\([0-9a-f]\{40\}\).*/\1/") && + git verify-pack -v pack-$packsha1.idx >packlist && + objsha1=$(head -n 1 packlist | sed -e "s/^\([0-9a-f]\{40\}\).*/\1/") &&We probably should lose reference to SHA-1 and use $OID_REGEX; this is obviously a #leftoverbits material that is outside the scope of this series.
Since the theme of this series is test cleanup, I believe that it's probably appropriate to roll these changes (and the ones below that I omitted) into the current series. Since it isn't too much work, I'll send them out in my next reroll.