Thread (2 messages) 2 messages, 2 authors, 2019-11-25

Re: [PATCH 2/8] built-in add -i: prepare for multi-selection commands

From: Johannes Schindelin <hidden>
Date: 2019-11-25 15:22:17

Hi Junio,

On Thu, 21 Nov 2019, Junio C Hamano wrote:
"Johannes Schindelin via GitGitGadget" [off-list ref]
writes:
quoted
From: Johannes Schindelin <redacted>

The `upgrade`, `revert` and `add-untracked` commands allow selecting
multiple entries. Let's extend the `list_and_choose()` function to
accommodate those use cases.
upgrade???
Whoooooops. "update", of course.
quoted
Signed-off-by: Johannes Schindelin <redacted>
---
 add-interactive.c | 114 ++++++++++++++++++++++++++++++++++++----------
 1 file changed, 89 insertions(+), 25 deletions(-)
diff --git a/add-interactive.c b/add-interactive.c
index 8ec930ac15..33a751150a 100644
--- a/add-interactive.c
+++ b/add-interactive.c
@@ -72,15 +72,17 @@ static void init_add_i_state(struct add_i_state *s, struct repository *r)
 struct prefix_item_list {
 	struct string_list items;
 	struct string_list sorted;
+	int *selected; /* for multi-selections */
 	size_t min_length, max_length;
 };
OK.  The shape of the data is enough to tell us what you did in this
patch and I think it makes sense ;-)
:-)

Thanks,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help