Re: [PATCH 01/11] fsmonitor: disable in a bare repo
From: Denton Liu <hidden>
Date: 2019-11-21 23:18:23
Hi Stolee, On Thu, Nov 21, 2019 at 10:20:16PM +0000, Derrick Stolee via GitGitGadget wrote:
From: Derrick Stolee <redacted> t0003-attributes.sh
Patches 1 and 2 have this line in the commit message. I assume it's a typo? Also, for the patches with empty commit message bodies, it would be nice if they were filled in with detail for _why_ the change is being made. For example, in this patch, a future reader might wonder why having fsmonitor enabled in a bare repo causes problems. Thanks, Denton
quoted hunk ↗ jump to hunk
Signed-off-by: Derrick Stolee <redacted> --- config.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/config.c b/config.c index 3900e4947b..f6d4e2fae3 100644 --- a/config.c +++ b/config.c@@ -2339,6 +2339,11 @@ int git_config_get_max_percent_split_change(void) int git_config_get_fsmonitor(void) { + if (!the_repository->worktree) { + core_fsmonitor = 0; + return 0; + } + if (git_config_get_pathname("core.fsmonitor", &core_fsmonitor)) core_fsmonitor = getenv("GIT_TEST_FSMONITOR");-- gitgitgadget