Re: [PATCH 2/3] t3206: demonstrate failure with notes

Denton Liu [off-list ref] writes:

When a commit being range-diff'd has a note attached to it, the note
will be compared as well. However, this shouldn't happen since the
purpose of range-diff is to compare the difference between two
commit-ranges and, since the note attached to a commit is mutable, they
shouldn't be included as part of the comparison.

I do not agree with the reasoning.  Commits in the new iteration of
the same series would have note attached to them that are different
from the note attached to corresponding commits in the old iteration.

Imagine that "git am" gets enhanced to store the per-iteration
comments you write under the three-dash lines (e.g. "fixed typo in
the log message pointed out by X") as notes attached to each of the
resulting commits.  It does make sense to compare the commits _with_
notes by default, if these notes are configured to be shown in "git
show" output by default for the user.

I do think that it may be a good idea to optionally allow comparison
without notes, when "--no-notes" is given to range-diff on the
command line, by passing the option through, though.

Thanks.