Thread (1 message) 1 message, 1 author, 2019-11-16

Re: [PATCH v3 09/10] pretty: implement 'reference' format

From: Junio C Hamano <hidden>
Date: 2019-11-16 01:46:56

SZEDER Gábor [off-list ref] writes:
On Fri, Nov 15, 2019 at 03:07:59PM +0900, Junio C Hamano wrote:
quoted
Denton Liu [off-list ref] writes:
quoted
+* 'reference'
+
+	  <abbrev hash> (<title line>, <short author date>)
s/title line/title/ as you definitely do *not* want a line with a
title on it (and nothing else) in this context.
Well, we just followed suit of the descriptions of other pretty
formats, and they all say "<title line>".

On a related note, the description of the '%s' format specifier in the
same document is "subject", not "title".  Perhaps they should be made
consistent, but I'm not sure.  I like that '%s' means "subject",
because the first letter matches, but some man pages (commit,
format-patch, am) make difference between a subject and a title.
Yeah, I think these are used more or less interchangeably, and we
may want to clarify the distinction.  Between the two, <title> is a
more appropriate "context neutral" name for the thing, i.e. one line
(technically, one paragraph) summary of what the commit is about.
Where <subject> becomes more relevant is when a commit is expressed
as a piece of patch e-mail, where <title> is used on the "Subject: "
header.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help