On Thu, Nov 07, 2019 at 05:51:09PM +0700, Danh Doan wrote:

On 2019-11-07 03:02:18 -0500, Jeff King wrote:

quoted

quoted

                git config i18n.commitencoding ISO-2022-JP &&
                echo ISO-2022-JP >>F &&
                git commit -a -F "$TEST_DIRECTORY/t3900/ISO-2022-JP.txt" &&

...you still can't just run this manually because of other lines like
this one.

Except we can with a little effort:

    export TEST_DIRECTORY=..

Sure, but if you allow setting variables, you could do the same for
"$msg", etc. :)

quoted

It's also weirdly unlike all of the other tests, which creates confusion
for people reading the code. IMHO the tradeoff isn't worth it.

Hm, I think it's the test_commit_autosquash_flag is the one that is weird
in this file. Most of other sets of tests (line 89-176) use the same quote.

Yeah, you're right. I did look at the other tests to see if it was an
existing style, but of course that was the exact one I looked at. ;)

IMHO it's still a bad style (and is unlike most of the rest of our
tests), but as it's following the existing style in the file, I can live
with it (and we can think about changing it all as a separate step
later).

-Peff