Re: [PATCH 1/1] [Outreachy] merge-ours: include parse-options
From: Junio C Hamano <hidden>
Date: 2019-11-02 04:14:49
Johannes Schindelin [off-list ref] writes:
Hi Junio, On Wed, 30 Oct 2019, Junio C Hamano wrote:quoted
"george espinoza via GitGitGadget" [off-list ref] writes:quoted
From: george espinoza <redacted> Teach this command which currently handles its own argv to use parse-options instead because parse-options helps make sure we handle user input like -h in a standardized way across the project.Sorry, but why do we even want to do this?It _is_ a command you can run via `git merge-ours` by mistake. Don't you think it would be nice for users to at least get a synopsis?
I think it would be good to tell users that the subcommand is not what they want to run directly, instead of the synopsis to tell them how to run it ;-). So no. But if merge-ours needs to learn its own -Xoption, it would make sense to first convert it to use parse-options API and then add the backend option support on top of it. And the patch under discussion in a polished form (by the way, has anybody pointed out that the use of the verb "include" is a bit strange there on the patch title?) would serve as a good first step for such a topic. Thanks.